Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cache org guard and fix roles guard apiv2 #15719

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

ThyMinimalDev
Copy link
Contributor

@ThyMinimalDev ThyMinimalDev commented Jul 10, 2024

What does this PR do?

Cache IsOrgGuard

fix RolesGuard bug introduces after adding caching

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

yarn test:e2e organizations-teams.controller.e2e-spec.ts

@graphite-app graphite-app bot requested a review from a team July 10, 2024 10:19
@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Jul 10, 2024
@graphite-app graphite-app bot requested a review from a team July 10, 2024 10:20
@dosubot dosubot bot added the api area: API, enterprise API, access token, OAuth label Jul 10, 2024
Copy link

graphite-app bot commented Jul 10, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (07/10/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (07/10/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link

vercel bot commented Jul 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2024 0:28am
cal ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2024 0:28am
calcom-web-canary ⬜️ Ignored (Inspect) Jul 10, 2024 0:28am

Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Eighty-one Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps 278.93 KB 506.56 KB 144.73% (🟢 -1.50%)
/apps/[slug] 296.49 KB 524.12 KB 149.75% (🟢 -1.51%)
/apps/[slug]/[...pages] 588.59 KB 816.22 KB 233.21% (🟢 -1.16%)
/apps/categories 256.24 KB 483.87 KB 138.25% (🟢 -1.23%)
/apps/categories/[category] 261.05 KB 488.68 KB 139.62% (🟢 -1.50%)
/apps/installation/[[...step]] 468.97 KB 696.6 KB 199.03% (🔴 +86.08%)
/apps/installed/[category] 278.2 KB 505.82 KB 144.52% (🟢 -1.83%)
/auth/saml-idp 12.22 KB 239.85 KB 68.53% (🟢 -20.80%)
/auth/setup 150.97 KB 378.59 KB 108.17% (🟡 +0.26%)
/availability 426.14 KB 653.77 KB 186.79% (🟢 -1.79%)
/availability/[schedule] 410.56 KB 638.19 KB 182.34% (🟢 -1.65%)
/bookings/[status] 326.17 KB 553.8 KB 158.23% (🟢 -1.15%)
/enterprise 256.3 KB 483.92 KB 138.26% (🟢 -1.23%)
/event-types 561.25 KB 788.88 KB 225.39% (🟢 -1.17%)
/event-types/[type] 437.8 KB 665.43 KB 190.12% (🟢 -1.06%)
/getting-started/[[...step]] 447.9 KB 675.53 KB 193.01% (🟡 +10.65%)
/insights 474.65 KB 702.28 KB 200.65% (🟢 -1.68%)
/more 255.8 KB 483.43 KB 138.12% (🟢 -1.23%)
/settings/admin 262.24 KB 489.87 KB 139.96% (🟢 -1.21%)
/settings/admin/apps 275.48 KB 503.11 KB 143.74% (🟢 -1.24%)
/settings/admin/apps/[category] 275.47 KB 503.09 KB 143.74% (🟢 -1.24%)
/settings/admin/flags 265.96 KB 493.59 KB 141.03% (🟢 -1.25%)
/settings/admin/impersonation 262.63 KB 490.26 KB 140.07% (🟢 -1.21%)
/settings/admin/lockedSMS 283.73 KB 511.35 KB 146.10% (🟢 -1.19%)
/settings/admin/oAuth 274.24 KB 501.86 KB 143.39% (🟢 -1.24%)
/settings/admin/orgMigrations/_OrgMigrationLayout 251.17 KB 478.8 KB 136.80% (🟢 -1.22%)
/settings/admin/orgMigrations/moveTeamToOrg 300.91 KB 528.53 KB 151.01% (🟢 -1.20%)
/settings/admin/orgMigrations/moveUserToOrg 320.74 KB 548.36 KB 156.67% (🟢 -1.17%)
/settings/admin/orgMigrations/removeTeamFromOrg 300.67 KB 528.3 KB 150.94% (🟢 -1.20%)
/settings/admin/orgMigrations/removeUserFromOrg 300.68 KB 528.31 KB 150.95% (🟢 -1.21%)
/settings/admin/organizations 264.13 KB 491.75 KB 140.50% (🟢 -1.21%)
/settings/admin/organizations/[id]/edit 262.79 KB 490.41 KB 140.12% (🟢 -1.22%)
/settings/admin/users 264.9 KB 492.52 KB 140.72% (🟢 -1.21%)
/settings/admin/users/[id]/edit 393.96 KB 621.58 KB 177.60% (🟢 -1.22%)
/settings/admin/users/add 393.62 KB 621.25 KB 177.50% (🟢 -1.22%)
/settings/billing 262.45 KB 490.07 KB 140.02% (🟢 -1.21%)
/settings/developer/api-keys 266.73 KB 494.36 KB 141.25% (🟢 -1.25%)
/settings/developer/webhooks 266.91 KB 494.53 KB 141.30% (🟢 -1.25%)
/settings/developer/webhooks/[id] 267.89 KB 495.51 KB 141.58% (🟢 -1.23%)
/settings/developer/webhooks/new 267.91 KB 495.54 KB 141.58% (🟢 -1.23%)
/settings/my-account/appearance 314.33 KB 541.96 KB 154.84% (🟢 -1.52%)
/settings/my-account/calendars 274.22 KB 501.84 KB 143.38% (🟢 -1.15%)
/settings/my-account/conferencing 272.2 KB 499.83 KB 142.81% (🟢 -1.98%)
/settings/my-account/general 377.85 KB 605.47 KB 172.99% (🟢 -1.23%)
/settings/my-account/out-of-office 267.37 KB 494.99 KB 141.43% (🟢 -1.25%)
/settings/my-account/profile 410.28 KB 637.91 KB 182.26% (🟢 -1.24%)
/settings/organizations/[id]/about 159.66 KB 387.28 KB 110.65% (🟡 +0.47%)
/settings/organizations/[id]/add-teams 159.65 KB 387.28 KB 110.65% (🟡 +0.47%)
/settings/organizations/admin-api 262.4 KB 490.03 KB 140.01% (🟢 -1.22%)
/settings/organizations/appearance 122.34 KB 349.96 KB 99.99% (🟢 -48.02%)
/settings/organizations/billing 262.48 KB 490.11 KB 140.03% (🟢 -1.21%)
/settings/organizations/dsync 295.1 KB 522.73 KB 149.35% (🟢 -1.21%)
/settings/organizations/general 350.69 KB 578.32 KB 165.23% (🟢 -1.23%)
/settings/organizations/members 400.51 KB 628.13 KB 179.47% (🟢 -1.62%)
/settings/organizations/new 159.66 KB 387.29 KB 110.65% (🟡 +0.47%)
/settings/organizations/privacy 267.89 KB 495.52 KB 141.58% (🟢 -1.25%)
/settings/organizations/profile 415.16 KB 642.79 KB 183.65% (🟡 +2.30%)
/settings/organizations/sso 273.07 KB 500.7 KB 143.06% (🟢 -1.22%)
/settings/organizations/teams/other 263.31 KB 490.94 KB 140.27% (🟢 -1.22%)
/settings/organizations/teams/other/[id]/appearance 275.11 KB 502.74 KB 143.64% (🟢 -1.19%)
/settings/organizations/teams/other/[id]/members 269.8 KB 497.43 KB 142.12% (🟢 -1.24%)
/settings/organizations/teams/other/[id]/profile 473.52 KB 701.15 KB 200.33% (🟢 -1.24%)
/settings/platform 260.9 KB 488.53 KB 139.58% (🟢 -1.23%)
/settings/platform/new 120.67 KB 348.3 KB 99.51% (🟡 +0.51%)
/settings/platform/oauth-clients/[clientId]/edit 259.21 KB 486.84 KB 139.10% (🟢 -1.23%)
/settings/platform/oauth-clients/create 258.35 KB 485.98 KB 138.85% (🟢 -1.23%)
/settings/security/impersonation 267.55 KB 495.17 KB 141.48% (🟢 -1.25%)
/settings/security/password 305.7 KB 533.33 KB 152.38% (🟢 -1.23%)
/settings/security/sso 272.52 KB 500.15 KB 142.90% (🟢 -1.22%)
/settings/security/two-factor-auth 271.03 KB 498.66 KB 142.47% (🟢 -1.24%)
/settings/teams 261.98 KB 489.6 KB 139.89% (🟢 -1.22%)
/settings/teams/[id]/appearance 275.1 KB 502.72 KB 143.64% (🟢 -1.20%)
/settings/teams/[id]/billing 262.48 KB 490.11 KB 140.03% (🟢 -1.21%)
/settings/teams/[id]/members 379.92 KB 607.55 KB 173.59% (🟢 -1.24%)
/settings/teams/[id]/profile 474.3 KB 701.93 KB 200.55% (🟢 -1.24%)
/settings/teams/new 193 KB 420.63 KB 120.18% (🟢 -1.83%)
/teams 256.03 KB 483.66 KB 138.19% (🟢 -1.23%)
/upgrade 256.15 KB 483.78 KB 138.22% (🟢 -1.23%)
/video/[uid] 291.19 KB 518.81 KB 148.23% (🟢 -0.18%)
/workflows 288.06 KB 515.68 KB 147.34% (🟢 -1.17%)
/workflows/[workflow] 414.6 KB 642.23 KB 183.49% (🟢 -1.44%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@ThyMinimalDev ThyMinimalDev merged commit 21f30fc into main Jul 10, 2024
36 checks passed
@ThyMinimalDev ThyMinimalDev deleted the cache-org-guard-fix-roles-guard branch July 10, 2024 15:46
verstratenbram added a commit to verstratenbram/cal.com that referenced this pull request Jul 16, 2024
* commit '0dd3b2562458522ad002b4ea967e2b10855a4ab6': (130 commits)
  chore: v4.2.5 (calcom#15735)
  fix: api v2 unit tests  (calcom#15733)
  fix: event type back button (calcom#15722)
  fix: remove console.log and tsignore apiv2 (calcom#15732)
  fix: api-v2 controllers e2e tests (calcom#15724)
  fix: Text in Embed Code  Visibility Fixed (calcom#15711)
  chore: sort calendar crendentials in event manager (calcom#15448)
  chore: cache org guard and fix roles guard apiv2 (calcom#15719)
  Revert "fix: Autodetection of time zone only updated default time zone (calcom#15392)" (calcom#15720)
  feat: add POST end point to mark calls as no-shows (calcom#15690)
  chore: add i18n to atoms (calcom#15698)
  fix: set conferencing apps as default (calcom#15376)
  fix: disable google-meet in user onboarding if google-calendar is not installed (calcom#15702)
  fix: Rescheduling email when there is broken calendar integration (calcom#15669)
  chore: v4.2.4 (calcom#15703)
  fix: 404s becoming 500s (calcom#15696)
  fix: delete reserved slot on booker unmount (calcom#15700)
  chore: add caching apiv2 roles guard (calcom#15694)
  refactor: handleNewBooking calcom#3 (calcom#15612)
  fix: incorrect booking seats full error on collective seated event (calcom#15602)
  ...

# Conflicts:
#	packages/emails/templates/attendee-request-email.ts
#	packages/emails/templates/attendee-was-requested-to-reschedule-email.ts
#	packages/emails/templates/organizer-cancelled-email.ts
#	packages/emails/templates/organizer-location-change-email.ts
#	packages/emails/templates/organizer-payment-refund-failed-email.ts
#	packages/emails/templates/organizer-request-email.ts
#	packages/emails/templates/organizer-request-reminder-email.ts
#	packages/emails/templates/organizer-requested-to-reschedule-email.ts
#	packages/emails/templates/organizer-rescheduled-email.ts
#	packages/emails/templates/organizer-scheduled-email.ts
p6l-richard pushed a commit to p6l-richard/cal.com-fork that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area: API, enterprise API, access token, OAuth core area: core, team members only platform Anything related to our platform plan ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants